feat(perf): Add tables to all tabs in landing v3 #28806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just adds the tables with their columns for all the landing v3 tables. The mobile tab still needs the react native check, but that can be addressed when I get to filling the rest of that tab out. Also adds basic tests for all the tabs.
Zylphrex
approved these changes
Sep 24, 2021
| @@ -54,7 +54,7 @@ type Props = { | |||
| organization: Organization; | |||
| location: Location; | |||
| setError: (msg: string | undefined) => void; | |||
| summaryConditions: string; | |||
| summaryConditions?: string; | |||
There was a problem hiding this comment.
Should this remain required? It's only optional on the exported Table component but the inner _Table should require it right?
vuluongj20
pushed a commit
that referenced
this pull request
Sep 30, 2021
This just adds the tables with their columns for all the landing v3 tables. The mobile tab still needs the react native check, but that can be addressed when I get to filling the rest of that tab out. Also adds basic tests for all the tabs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This just adds the tables with their columns for all the landing v3 tables. The mobile tab still needs the react native check, but that can be addressed when I get to filling the rest of that tab out. Makes
summaryConditionsoptional with an FC wrapper, which I'll likely addusePageErrorto as well in the future, but for now I don't want to change too much. Also adds basic tests for all the tabs.