feat(perf): Add page error context #28805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splitting off more pieces from the perf. landing v3. This is just a page error context which can be used without drilling setError everywhere. Added a simple test so it's not just implicitly tested.
Zylphrex
approved these changes
Sep 23, 2021
| }; | ||
|
|
||
| export const PageErrorAlert = () => { | ||
| const {pageError} = useContext(pageErrorContext); |
There was a problem hiding this comment.
Can this use the usePageError hook you defined below?
vuluongj20
pushed a commit
that referenced
this pull request
Sep 30, 2021
Splitting off more pieces from the perf. landing v3. This is just a page error context which can be used without drilling setError everywhere. Added a simple test so it's not just implicitly tested.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Splitting off more pieces from the perf. landing v3. This is just a page error context which can be used without drilling setError everywhere. Added a simple test so it's not just implicitly tested.