-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add metric for durations of symbolicate_event requests [NATIVE-185] #28791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5363b31.
relaxolotl
approved these changes
Sep 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #28565. It endows
RealTimeMetricsStore
(and its Redis implementation) with a functionincrement_project_duration_counter(project_id, timestamp, duration)
that records the fact that attimestamp
, we received a request for projectproject_id
that tookduration
seconds to process. In the concrete Redis case, the event is first placed into a bucket based on the project id, bucket size, and time window; the bucket's value is a hash containing a counter for each 10-second interval of possible durations.By way of example, assume these method calls (17 being a randomly chosen project id):
Then the bucket
symbolicate_event_low_priority:histogram:10:17:1140
contains the hash