feat(release-archives): Add spans to fetch_release_archive_for_url #28790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Sep 23, 2021
tonyo
approved these changes
Sep 23, 2021
| cache.set(cache_key, file_.read(), 3600) | ||
| with sentry_sdk.start_span(op="fetch_release_archive_for_url.read_for_caching"): | ||
| contents = file_.read() | ||
| with sentry_sdk.start_span(op="fetch_release_archive_for_url.write_to_cache"): |
There was a problem hiding this comment.
Perhaps would be helpful to add the size of "contents" to the span as additional data, to check if there's correlation between size and time.
There was a problem hiding this comment.
I think this makes sense.. probably should do this for every span. Keep in mind we don't have access to local vars in performance product
vuluongj20
pushed a commit
that referenced
this pull request
Sep 30, 2021
…28790) Add more instrumentation to function that triggers soft timeouts. https://getsentry.atlassian.net/browse/INGEST-116
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more instrumentation to function that triggers frequent soft timeouts.
https://getsentry.atlassian.net/browse/INGEST-116