ref(js): Remove heavyweight organization #28783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
153f114 to
2f4a881
Compare
| }); | ||
| const org = TestStubs.Organization(); | ||
| delete org.teams; | ||
| delete org.projects; |
There was a problem hiding this comment.
should we remove the properties teams and projects from the Organization Stub?
There was a problem hiding this comment.
Yeah we should.
I will be following up with more test cleanup
| await tick(); | ||
| wrapper.update(); | ||
| expect(wrapper.text()).toContain('Deletion Scheduled'); | ||
| expect(wrapper.text()).toContain( |
There was a problem hiding this comment.
this reminds me a lot of RTL 👏😀
There was a problem hiding this comment.
While it may look like I rewrote these tests, I actually just moved things around 😆
|
Tested this locally and it looks great!! 👏👏 |
|
Preload changes look good 👍 |
2f4a881 to
68f6df2
Compare
davidenwang
approved these changes
Sep 24, 2021
| {/* A route tree for lightweight organizational detail views. | ||
| This is strictly for deprecated URLs that we need to maintain */} | ||
| <Route component={errorHandler(LightWeightOrganizationDetails)}> | ||
| <Route component={errorHandler(OrganizationDetails)}> |
There was a problem hiding this comment.
eventually should we have these under the same <Route> as the one above?
68f6df2 to
58a2299
Compare
vuluongj20
pushed a commit
that referenced
this pull request
Sep 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely removes the
LightweightOranizationtype. All organizations are now lightweight.All usages of
org.teamsandorg.projectshave been removed, all components now read out of the projects and teams store, meaning there is no need to ever hydrate the full object.