fix(api): Fix logging so that it shows properly on stackdriver #28777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log messages were not showing up on stack driver because they were not in the correct format.
JoshFerge
approved these changes
Sep 22, 2021
JoshFerge
reviewed
Sep 22, 2021
| @@ -176,9 +176,9 @@ def _create_api_access_log(self): | |||
| user=str(self.request.user), | |||
| token_type=token_name, | |||
| ) | |||
| api_access_logger.info(log_metrics) | |||
| api_access_logger.info("api.access", extra=log_metrics) | |||
| except Exception: | |||
There was a problem hiding this comment.
where in the above do we expect it to error out? could we catch more specific exceptions?
There was a problem hiding this comment.
I'm catching a generic exception because I don't want API requests to fail because of any logging error. As for where it could error out, most likely trying to access data members that don't exist, or key errors.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log messages were not showing up on stack driver because they were not in the correct format.