fix(notifications): Include experiment fallback in the serializer #28772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So my current theory is that the
notification-slack-automatic
feature flag is causing users to be opted into new Slack notifications, but when they're checking their settings, they only see that EMAIL is selected.In the DB, this example user only has EMAIL notification settings.
My solution is to change the way we calculate "fallback" settings in the serializer to check the feature flag. It won't turn off notifications for the user, but it will allow them to turn them off themselves.