fix(ui): Adjust platform lists for mobile #28766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The platform lists in platform categories should at least have a comprehensive list of platforms including outdated platforms due to doc changes, so that older projects can be matched against. Long term we should probably export PLATFORM_TO_ICONs from our platformicons library and run tests to ensure platforms in the platform categories files always match against our platform badge list at least.
evanpurkhiser
approved these changes
Sep 22, 2021
taylangocmen
approved these changes
Sep 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The platform lists in platform categories should at least have a comprehensive list of platforms including outdated platforms due to doc changes, so that older projects can be matched against.
Long term we should probably export
PLATFORM_TO_ICONSfrom our platformicons library and run tests to ensure platforms in the platform categories files always match against our platform badge list at least.The mobile category is used in only one case outside of performance that I can see after a quick look, which is the
isMobilePlatformcheck in events titles.