Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(alert-rules): Append new alert rule payload for issue alerts w/ ui components #28764

Merged
merged 4 commits into from
Oct 4, 2021
Merged

feat(alert-rules): Append new alert rule payload for issue alerts w/ ui components #28764

merged 4 commits into from
Oct 4, 2021

Conversation

leeandher
Copy link
Member

@leeandher leeandher commented Sep 22, 2021 •
edited
Loading

See API-2082

This PR will add the new payload onto the webhook which fires for alert rule components only if they

Demo:

Creating a new rule with UI components:
https://user-images.githubusercontent.com/35509934/134583968-868f1c6f-39c4-42ce-9b48-76a85eddd61c.mov

Edits are reflected in the payloads going forward:
https://user-images.githubusercontent.com/35509934/134583947-5b75de40-81a7-4511-b11f-33ca01a09077.mov

Existing sentry app webhooks are unaffected:
https://user-images.githubusercontent.com/35509934/134585331-e6bdac15-8f7c-419d-9697-94de77b62aad.mov

@leeandher leeandher changed the base branch from master to API-2078/leander/ia-endpoints September 22, 2021 20:57
@leeandher leeandher force-pushed the API-2078/leander/ia-endpoints branch from 0d58101 to d96ef95 Compare September 22, 2021 23:07
@leeandher leeandher marked this pull request as ready for review September 23, 2021 21:17
@leeandher leeandher requested a review from a team September 23, 2021 21:17
@leeandher leeandher force-pushed the API-2078/leander/ia-endpoints branch from d8d6505 to 0fa6547 Compare September 29, 2021 16:52
@leeandher leeandher marked this pull request as draft September 30, 2021 22:33
@leeandher leeandher marked this pull request as ready for review September 30, 2021 23:56
Base automatically changed from API-2078/leander/ia-endpoints to master October 1, 2021 20:07
@leeandher leeandher requested a review from a team October 4, 2021 16:36
@leeandher leeandher removed the request for review from a team October 4, 2021 16:38
@leeandher leeandher merged commit e66ec0c into master Oct 4, 2021
@leeandher leeandher deleted the leander/API-2082 branch October 4, 2021 17:04
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mgaeta mgaeta mgaeta approved these changes

Assignees
No one assigned
Labels
Component: Integrations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leeandher @mgaeta