Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(select): Choices -> options metricWidget #28753

Merged
merged 1 commit into from
Sep 22, 2021
Merged

ref(select): Choices -> options metricWidget #28753

merged 1 commit into from
Sep 22, 2021

Conversation

davidenwang
Copy link
Contributor

switches from legacy react-select choices to options here:

image

@davidenwang davidenwang requested review from a team and priscilawebdev September 21, 2021 23:55
@davidenwang davidenwang force-pushed the davidenwang/metric-widget-choices-to-options branch from c388162 to c694bb9 Compare September 22, 2021 18:46
@davidenwang
Copy link
Contributor Author

/gcbrun

2 similar comments
@vuluongj20
Copy link
Member

/gcbrun

@billyvg
Copy link
Member

billyvg commented Sep 22, 2021

/gcbrun

@davidenwang davidenwang merged commit cc5797b into master Sep 22, 2021
@davidenwang davidenwang deleted the davidenwang/metric-widget-choices-to-options branch September 22, 2021 22:05
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evanpurkhiser evanpurkhiser evanpurkhiser approved these changes

@priscilawebdev priscilawebdev priscilawebdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidenwang @vuluongj20 @billyvg @evanpurkhiser @priscilawebdev