fix(discover): Handle field aliases with others correctly #28751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The Other query doesn't include any selected columns which means that using the FIELD_ALIAS's alias won't have a corresponding column - This fixes that issue by pulling the column from the selected columns and uses it in the conditions
wmak
commented
Sep 21, 2021
Comment on lines
-644
to
-646
| elif field in FIELD_ALIASES: | ||
| snuba_filter.conditions.append([field, "IN", values]) | ||
| other_conditions.append([field, "NOT IN", values]) |
There was a problem hiding this comment.
The block above to generate resolved_field means this is no longer needed
Zylphrex
approved these changes
Sep 23, 2021
vuluongj20
pushed a commit
that referenced
this pull request
Sep 30, 2021
* fix(discover): Handle field aliases with others correctly - The Other query doesn't include any selected columns which means that using the FIELD_ALIAS's alias won't have a corresponding column - This fixes that issue by pulling the column from the selected columns and uses it in the conditions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using the FIELD_ALIAS's alias won't have a corresponding column
and uses it in the conditions