feat(alerts): Add project incident aler to proj/issue stream page - NATIVE-216 & NATIVE-217 #28726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priscilawebdev
commented
Sep 21, 2021
| @@ -561,6 +561,9 @@ def serialize(self, obj, attrs, user): | |||
| "hasAccess": attrs["has_access"], | |||
| "dateCreated": obj.date_added, | |||
| "environments": attrs["environments"], | |||
| "eventProcessing": { | |||
There was a problem hiding this comment.
this will be changed later by the backend team.
|
That stack of alerts at the top of the issue view is awkward. Do we have plans to revisit that? |
57715b0 to
8f02db7
Compare
|
thanks for the feedback @markstory, we've decided to move this alert from the issue details page to the stream page (temp solution), which makes more sense but is still not ideal. @Jesse-Box is already working on a better solution that will be implemented in a separate PR |
6d850d5 to
d3f7245
Compare
vuluongj20
pushed a commit
that referenced
this pull request
Sep 30, 2021
…ATIVE-216 & NATIVE-217 (#28726)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previews:
Project Details
Issue Stream
ps:
Closes: NATIVE-216 and NATIVE-217