ref(select): Choices -> options RuleNode #28712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidenwang
commented
Sep 21, 2021
| @@ -81,7 +81,7 @@ class RuleNode extends React.Component<Props> { | |||
| // | |||
| // However there are integrations that give the form field choices with the value as number, but | |||
| // when the integration configuration gets saved, it gets saved and returned as a string | |||
| const choices = fieldConfig.choices.map(([key, value]) => [`${key}`, value]); | |||
| const options = fieldConfig.choices.map(([value, label]) => ({value, label})); | |||
There was a problem hiding this comment.
changed the names here cuz it was a little misleading, value is the first index of the array and the label is the second
scttcper
approved these changes
Sep 21, 2021
matejminar
approved these changes
Sep 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from choices to options here:
