ref(js): Remove usage of organization.projects from SidebarOrgSummary #28705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidenwang
reviewed
Sep 20, 2021
| const fullOrg = organization as Organization; | ||
| const projects = fullOrg.projects && fullOrg.projects.length; | ||
| // Extra may be used to add additional details under the organization name. | ||
| // This is currently unused. |
There was a problem hiding this comment.
i guess if its currently unused should we just remove it entirely?
85a9b1f to
09cdde6
Compare
09cdde6 to
7d2fcaf
Compare
7d2fcaf to
0309cbf
Compare
davidenwang
approved these changes
Sep 22, 2021
|
|
||
| const OrgSummary = styled('div')` | ||
| display: flex; | ||
| padding: 10px 15px; | ||
| display: grid; |
There was a problem hiding this comment.
ooh nice clean up here
There was a problem hiding this comment.
yeah basically just rewrote it all lol
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.