fix(js): Make confirm prop of SelectField less complex
#28681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6121d4d to
7e6e852
Compare
evanpurkhiser
commented
Sep 20, 2021
| * if the value object has a `value` attribute in the option. The types do | ||
| * not correctly reflect this so be careful! | ||
| */ | ||
| connfirm?: Record<string, React.ReactFragment>; |
There was a problem hiding this comment.
can't even name it right lol
7e6e852 to
51800fb
Compare
davidenwang
approved these changes
Sep 20, 2021
| // Support 'confirming' selections. This only works with | ||
| // `val` objects that use the new-style options format | ||
| const previousValue = props.value?.toString(); | ||
| const newValue = val.value?.toString(); |
There was a problem hiding this comment.
could the toString here cause some weirdness when comparing values? Or is it necessary because of the constraints react-select has for string values.
There was a problem hiding this comment.
Yeah idk, this is copy over from what was implemented already. cc @mgaeta
There was a problem hiding this comment.
Sorry I don't remember why we had to add the toString() calls.
There was a problem hiding this comment.
Just for future reference, would be a good time for a comment :)
51800fb to
e63c36c
Compare
e63c36c to
e7fa685
Compare
mgaeta
approved these changes
Sep 20, 2021
mgaeta
reviewed
Sep 20, 2021
e7fa685 to
dc4b373
Compare
- Removes the changes made to the Confirm modal in favor of keeping that state inn the closure of the `onChange` of `openConfirmModal` - Stops _every_ SelectField from being wrapped in a `Confirm`, since most selects will not be doing confirmation. This is replaced with a simpler call to openConfirmModal.
dc4b373 to
e79ea0b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the changes made to the Confirm modal in favor of keeping that state inn the closure of the
onChangeofopenConfirmModalStops every SelectField from being wrapped in a
Confirm, since most selects will not be doing confirmation. This is replaced with a simpler call to openConfirmModal.