ref(js): Cleanup notification/utils.tsx #28679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move documentation comments above the function so LSP correctly picks up on them - Reduce some nesting with guard statements
mgaeta
approved these changes
Sep 20, 2021
billyvg
approved these changes
Sep 20, 2021
| @@ -385,8 +384,6 @@ export const getParentField = ( | |||
| parentId: string | |||
| ) => NotificationSettingsObject | |||
| ): FieldObject => { | |||
| /** Render each parent and add a default option to the the field choices. */ | |||
There was a problem hiding this comment.
What are you thinking?
There was a problem hiding this comment.
idk if there's a lint rule for it
There was a problem hiding this comment.
Like no comments like /** ... */?
Or also auto wrapping?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move documentation comments above the function so LSP correctly picks
up on them
Reduce some nesting with guard statements