Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(interface-breadcrumbs): Apply feedback & fix minor issue #28674

Merged
merged 1 commit into from
Sep 20, 2021
Merged

ref(interface-breadcrumbs): Apply feedback & fix minor issue #28674

merged 1 commit into from
Sep 20, 2021

Conversation

priscilawebdev
Copy link
Member

@priscilawebdev priscilawebdev commented Sep 20, 2021 •
edited
Loading

  • Spacing on the left and right of an icon has to be 16px
  • Renamed StyledTag to LevelTag
  • Fix scrollbar size on smaller devices - safari
    Before:

image

After:

image

  • Fix border not being fully visible on smaller devices - chrome

Before:
image

After:

image

priscilawebdev
priscilawebdev commented Sep 20, 2021
View reviewed changes
static/app/utils/theme.tsx
@@ -481,12 +481,6 @@ const commonTheme = {
// does not need to battle others for z-index priority
initial: 1,

breadcrumbs: {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is no longer used

@priscilawebdev priscilawebdev requested a review from a team September 20, 2021 14:12
matejminar
matejminar approved these changes Sep 20, 2021
View reviewed changes
static/app/components/events/interfaces/breadcrumbs/breadcrumb/level.tsx
);
}
});

export default Level;

const StyledTag = styled(Tag)`
const LevelTag = styled(Tag)`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@priscilawebdev priscilawebdev enabled auto-merge (squash) September 20, 2021 14:19
@priscilawebdev priscilawebdev merged commit a6a3cba into master Sep 20, 2021
@priscilawebdev priscilawebdev deleted the ref/crumbs-feedback branch September 20, 2021 14:44
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dashed dashed dashed approved these changes

@matejminar matejminar matejminar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@priscilawebdev @dashed @matejminar