test(metrics): Write all session metrics in test [INGEST-386] #28667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaduW
approved these changes
Sep 20, 2021
| @@ -1,4 +1,5 @@ | |||
| from typing import Optional | |||
| import itertools | |||
| from typing import DefaultDict, Optional | |||
There was a problem hiding this comment.
Shouldn't you import defaultdict from collections rather than this, since you are not using
it as typeinfo but you are instantiating it
There was a problem hiding this comment.
Whoops yes, this was an auto-import I did not pay attention to.
| @@ -18,25 +19,43 @@ | |||
| "staging": 10, | |||
| "user": 11, | |||
| "init": 12, | |||
| "session.error": 13, | |||
| } | |||
There was a problem hiding this comment.
Nit. Why a dictionary here since all the indexes are sequential, a simple array would do (and just use the index in the array as the value).
|
|
||
| def __init__(self): | ||
| self._counter = itertools.count(start=len(_STRINGS)) | ||
| self._strings = DefaultDict(self._counter.__next__) |
There was a problem hiding this comment.
As commented above I don't think typings.DefaultDict is supposed to be used like this, could we use collections.defaultdict instead ?
RaduW
approved these changes
Sep 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write more session metrics to snuba in metrics test case, mimicking the
extract_session_metricsfunction in relay.This prepares for https://getsentry.atlassian.net/browse/INGEST-386.