fix(jira): More explicitly excise itemKey in removeRow
#28664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ex-d
suggested changes
Sep 18, 2021
Comment on lines
+143
to
+145
| saveChanges( | ||
| Object.fromEntries(Object.entries(value).filter(([key, _]) => key !== itemKey)) | ||
| ); |
There was a problem hiding this comment.
I think we should put the saveChanges param to a clearer identifier or write a comment explaining what is happening here for readability purpose.
NisanthanNanthakumar
approved these changes
Sep 20, 2021
| const {[itemKey]: _, ...updatedValue} = value; | ||
| saveChanges(updatedValue); | ||
| saveChanges( | ||
| Object.fromEntries(Object.entries(value).filter(([key, _]) => key !== itemKey)) |
There was a problem hiding this comment.
Object.fromEntries(Object.entries(value).filter(([key]) => key !== itemKey))
You don't need the underscore, you would only need that if you didn't care about earlier indexes in the array.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.