Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(ui): Rename RuleConditionsFormForWizard and change legacy choices to options #28662

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

davidenwang
Copy link
Contributor

This was previously named ForWizard because the alert wizard was feature flagged and there existed a non wizard version of the alert builder, but now we can just rename it to RuleConditionsForm.

Also changed choices -> options to get rid of this legacy react-select stuff.

image

@davidenwang davidenwang requested review from a team September 17, 2021 23:18
@davidenwang davidenwang merged commit a82ea58 into master Sep 21, 2021
@davidenwang davidenwang deleted the davidenwang/wizard-form-options-to-choices branch September 21, 2021 00:30
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants