fix(discover): Should reload when payload changes while loading #28653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the eventView changes while the request is in-flight/loading, we should cancel the in-flight request and fetch again. This is problematic in cases where the request takes a little longer to load and the user changes the query while it is still in-flight. If a reload is not triggered at this time, the results are actually incorrect since it's showing the results from the previous (stale) in-flight request.
Zylphrex
commented
Sep 17, 2021
Comment on lines
+202
to
+203
| // clear any inflight requests since they are now stale | ||
| api.clear(); |
There was a problem hiding this comment.
Does this have the potential to cancel other requests unintentionally? 🤔
There was a problem hiding this comment.
The cancellation only occurs for the Client instance of api. Not other Client instances.
There was a problem hiding this comment.
basically it depends on how you pass in api, I think perhaps we should make these instances unique now with useAPI()
dashed
approved these changes
Sep 17, 2021
0ex-d
approved these changes
Sep 18, 2021
k-fish
approved these changes
Sep 21, 2021
vuluongj20
pushed a commit
that referenced
this pull request
Sep 30, 2021
If the eventView changes while the request is in-flight/loading, we should cancel the in-flight request and fetch again. This is problematic in cases where the request takes a little longer to load and the user changes the query while it is still in-flight. If a reload is not triggered at this time, the results are actually incorrect since it's showing the results from the previous (stale) in-flight request.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the eventView changes while the request is in-flight/loading, we should
cancel the in-flight request and fetch again. This is problematic in cases where
the request takes a little longer to load and the user changes the query while
it is still in-flight. If a reload is not triggered at this time, the results
are actually incorrect since it's showing the results from the previous (stale)
in-flight request.