fix(releases): Create distributions if missing in JS code path [INGEST-240] #28647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
commented
Sep 17, 2021
| @@ -675,14 +675,6 @@ def add_dist(self, name, date_added=None): | |||
| defaults={"date_added": date_added, "organization_id": self.organization_id}, | |||
| )[0] | |||
|
|
|||
| def get_dist(self, name): | |||
There was a problem hiding this comment.
I removed this function because it is not used anywhere else, and its callers are at risk of confusing "does not exist" with dist=None i.e. the default distribution.
mitsuhiko
approved these changes
Sep 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the same way that releases are created when missing in javascript processing (see #5472) , add missing distributions to the db.
This fixes #28048.
https://getsentry.atlassian.net/browse/INGEST-240