feat(dashboards): Dashboard Widgets Open in Discover button redirects with all selected Y-Axis from the Widget #28637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er-multi-y-axis-checkbox-dropdown
update to allow deselecting all y axis added y axis selection restriction based on plot type default to count() on empty y axis fixed tests
wmak
approved these changes
Sep 17, 2021
| @@ -38,6 +38,9 @@ class DashboardWidgetQuerySelectorModal extends React.Component<Props> { | |||
| selection, | |||
| widget.displayType | |||
| ); | |||
| const discoverLocation = eventView.getResultsViewUrlTarget(organization.slug); | |||
| // Pull Y-Axis from the widget | |||
| discoverLocation.query.yAxis = query.fields; | |||
There was a problem hiding this comment.
Is it possible for query.fields to contain yAxis incompatible fields here?
There was a problem hiding this comment.
Good call, I've added some checks to ensure we only use compatible fields via eventView.getYAxisOptions and also made sure to limit to 3 yAxis max as the table widget allows 3+ fields to be selected..
Base automatically changed from
feat/discover-multi-y-axis
to
feat/discover-multi-y-axis-checkbox-dropdown
September 20, 2021 16:13
Base automatically changed from
feat/discover-multi-y-axis-checkbox-dropdown
to
master
September 20, 2021 17:05
…en-in-discover-multi-y-axis
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
Open in Discoverlinks in Dashboard Widgets to redirect with all Y-Axis selected from the Widget rather than using only the first Y-Axis from the Widget.