ref(notifications): Clean up Team Notifications for Issue Owners #28624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceorourke
reviewed
Sep 16, 2021
ceorourke
reviewed
Sep 16, 2021
ceorourke
reviewed
Sep 16, 2021
ceorourke
reviewed
Sep 16, 2021
| ) | ||
| } | ||
| ) | ||
| except pytz.UnknownTimeZoneError: | ||
| ... |
There was a problem hiding this comment.
Ok I just looked this up ... is the Ellipses Object. It is has various uses but in this case it was being used as a dummy statement in the same way we use pass.
ceorourke
reviewed
Sep 16, 2021
ceorourke
reviewed
Sep 16, 2021
added 6 commits
September 16, 2021 14:45
8a80a49 to
be159ed
Compare
NisanthanNanthakumar
approved these changes
Sep 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was supposed to be a simple refactor of
filter_to_subscribed_users()but turned into a complete rewrite of types for the Notifications Platform.