Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade grpcio #28623

Merged
merged 1 commit into from
Sep 16, 2021
Merged

chore: upgrade grpcio #28623

merged 1 commit into from
Sep 16, 2021

Conversation

joshuarli
Copy link
Member

This is needed for M1 development. I checked back on the old GRPC_POLL_STRATEGY=epoll1 workaround but it's still needed. Don't really see anything interesting/relevant in the changelog, most of it is just build changes for different arches.

@joshuarli joshuarli requested a review from a team as a code owner September 16, 2021 00:36
@armenzg
Copy link
Member

armenzg commented Sep 16, 2021

Hi Josh, what specific of that version is needed for M1? I thought updating to 1.39.0 was good enough (at least on my Python 3.8 setup).

@joshuarli
Copy link
Member Author

Hi Josh, what specific of that version is needed for M1? I thought updating to 1.39.0 was good enough (at least on my Python 3.8 setup).

There's practically no difference with 1.40.0, might as well.

@joshuarli joshuarli merged commit 7a3c32b into master Sep 16, 2021
@joshuarli joshuarli deleted the py38/upgrade-grpcio branch September 16, 2021 18:42
@armenzg
Copy link
Member

armenzg commented Sep 16, 2021

Oh I see. So you're simply bringing them to parity. Thanks for taking care of it!

matejminar pushed a commit that referenced this pull request Sep 17, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants