Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(select): Choices -> options AppStoreConnect #28616

Merged
merged 1 commit into from
Sep 16, 2021
Merged

ref(select): Choices -> options AppStoreConnect #28616

merged 1 commit into from
Sep 16, 2021

Conversation

davidenwang
Copy link
Contributor

Changes from legacy react-select choices to options in step 2 and step 5 of this modal
image

priscilawebdev
priscilawebdev approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@priscilawebdev priscilawebdev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally and it looks good

@davidenwang davidenwang force-pushed the davidenwang/choices-to-options-app-store-connect branch from 3ba0953 to 467dd1f Compare September 16, 2021 17:30
@davidenwang davidenwang enabled auto-merge (squash) September 16, 2021 20:58
@davidenwang davidenwang merged commit 70d97b6 into master Sep 16, 2021
@davidenwang davidenwang deleted the davidenwang/choices-to-options-app-store-connect branch September 16, 2021 20:59
matejminar pushed a commit that referenced this pull request Sep 17, 2021
@davidenwang @matejminar
ref(select): Choices -> options AppStoreConnect (#28616)
1362c70 
Changes from legacy react-select choices to options in step 2 and step 5 of this modal
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@priscilawebdev priscilawebdev priscilawebdev approved these changes

@evanpurkhiser evanpurkhiser Awaiting requested review from evanpurkhiser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidenwang @priscilawebdev