fix(icon): replaced Clubhouse logo #28612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jesse-Box
reviewed
Sep 16, 2021
|
@Jesse-Box it's an issue creation integration so a small b&w version is used on the issue details page so the user can create or view an already created Shortcut/Clubhouse issue. |
leeandher
reviewed
Sep 17, 2021
leeandher
requested changes
Sep 17, 2021
0218213 to
a8c8b74
Compare
| @@ -102,6 +102,7 @@ export const ICON_PATHS = { | |||
| rocketchat, | |||
| rookout, | |||
| segment, | |||
| shortcut: clubhouse, | |||
There was a problem hiding this comment.
Can we rename the file too?
There was a problem hiding this comment.
That’s what I tried at first but it broke the icon and wouldn’t display. Spent a bunch of time trying to figure out why that’s the case but I was thoroughly stumped.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching out the Clubhouse logo because of their rebranding. Now it’s called Shortcut. This change affects the following:
1. The Clubhouse and Shortcut integrations
2. Linked Issues icon in the issue details page