Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(appconnect): remove feature flag (NATIVE-241) #28588

Merged
merged 3 commits into from
Sep 20, 2021

Conversation

flub
Copy link
Contributor

@flub flub commented Sep 15, 2021

This removes the feature flag now that the feature is GA. Once merged
the feature flag can also be deleted from flagr.

This removes the feature flag now that the feature is GA.  Once merged
the feature flag can also be deleted from flagr.
@flub flub changed the title ref(appconnect): remove feature flag ref(appconnect): remove feature flag (NATIVE-241) Sep 15, 2021
Copy link
Member

@priscilawebdev priscilawebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. Looks good to me

@flub
Copy link
Contributor Author

flub commented Sep 15, 2021

tested locally and everything keeps working as expected.

Copy link

@0ex-d 0ex-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@flub flub marked this pull request as ready for review September 20, 2021 08:49
@flub flub requested a review from a team September 20, 2021 08:49
@flub flub merged commit 5e359d1 into master Sep 20, 2021
@flub flub deleted the ref/cleanup-appstoreconnect-feature-flag branch September 20, 2021 08:51
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants