Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): Dont show a dash when alert activity date is missing #28584

Merged
merged 1 commit into from
Sep 15, 2021
Merged

fix(ui): Dont show a dash when alert activity date is missing #28584

merged 1 commit into from
Sep 15, 2021

Conversation

taylangocmen
Copy link
Contributor

@taylangocmen taylangocmen commented Sep 14, 2021 •
edited
Loading

This removes the - for when the last incident date is missing for an alert, so next to alert status there's nothing.

Before
a. Normally:
Screen Shot 2021-09-14 at 4 44 31 PM
b. When date is missing:
Screen Shot 2021-09-14 at 4 43 59 PM

After
When date is missing:
Screen Shot 2021-09-14 at 4 44 07 PM

Jira: WOR-1160

@taylangocmen taylangocmen requested review from robinrendle and a team September 14, 2021 23:48
robinrendle
robinrendle approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@robinrendle robinrendle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heck yeah

@taylangocmen taylangocmen merged commit a2c86df into master Sep 15, 2021
@taylangocmen taylangocmen deleted the taylangocmen/fix-alert-activity-date-dashed-line branch September 15, 2021 17:29
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robinrendle robinrendle robinrendle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taylangocmen @robinrendle