feat(team-selector): Implement useTeams hook for searching #28547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
246697c to
4a0e3ba
Compare
4a0e3ba to
c36f31a
Compare
c36f31a to
a9d7bd7
Compare
a9d7bd7 to
130790e
Compare
130790e to
ea928c5
Compare
ea928c5 to
75ef088
Compare
75ef088 to
60ae8b4
Compare
davidenwang
approved these changes
Sep 15, 2021
| @@ -249,12 +251,14 @@ function TeamSelector(props: Props) { | |||
| <SelectControl | |||
| ref={selectRef} | |||
| options={options} | |||
| onInputChange={debounce(val => void onSearch(val), DEFAULT_DEBOUNCE_DURATION)} | |||
There was a problem hiding this comment.
is the void here just for typing or does debounce do something with the return value of the debounced func?
There was a problem hiding this comment.
yeah the onInputChange will actually try and render what is returned here, hence the void.
I could also write as { ... }
| teams: Team[]; | ||
| /** | ||
| * This is an action provided to consumers for them to update the current | ||
| * teams result set using a simple search query. You can allow the new |
There was a problem hiding this comment.
this comment can be changed to remove the bit about appending/replacing
| @@ -26,16 +27,11 @@ const teamData = [ | |||
| ]; | |||
| const teams = teamData.map(data => TestStubs.Team(data)); | |||
| const project = TestStubs.Project({teams: [teams[0]]}); | |||
| const organization = TestStubs.Organization({access: ['project:write']}); | |||
There was a problem hiding this comment.
oh shoot thanks for this, looks much better
There was a problem hiding this comment.
needed to update it since it doesn't take those as props now :)
| expect(mockRequest).toHaveBeenCalled(); | ||
| expect(result.current.teams).toEqual([...mockTeams, newTeam2, newTeam3]); | ||
|
|
||
| // de-duplicates itesm in the query results |
60ae8b4 to
d008acd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This react hook allows us to easily implement type-ahead for teams.
In the future this will also support loading specific teams, and loading teams that you're a part of. We may potentially even add support to incrementally load results via pagination.