ref(deletion) Consolidate group deletion and improve logging #28475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had two different implementations of group deletion. This change consolidates those into a single path and fixes split group hashes being removed by list page delete operations. I've also added the organization_id to group deletion messages. This helps improve log queries like 'did acme org delete any issues recently' which comes up when customers notice discrepancies between the events they currently have and the usage we've tracked.
untitaker
approved these changes
Sep 16, 2021
matejminar
pushed a commit
that referenced
this pull request
Sep 17, 2021
We had two different implementations of group deletion. This change consolidates those into a single path and fixes split group hashes being removed by list page delete operations. I've also added the organization_id to group deletion messages. This helps improve log queries like 'did acme org delete any issues recently' which comes up when customers notice discrepancies between the events they currently have and the usage we've tracked.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had two different implementations of group deletion. This change consolidates those into a single path and fixes split group hashes being removed by list page delete operations.
I've also added the organization_id to group deletion messages. This helps improve log queries like 'did acme org delete any issues recently' which comes up when customers notice discrepancies between the events they currently have and the usage we've tracked.