Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(deletion) Remove unused deletion tasks #28463

Merged
merged 6 commits into from
Sep 23, 2021
Merged

Conversation

markstory
Copy link
Member

With all of these async deletions being done with ScheduledDeletion we no longer need to have these tasks and their tests around.

With all of these async deletions being done with ScheduledDeletion we
no longer need to have these tasks and their tests around.
@markstory markstory requested a review from a team September 9, 2021 15:13
Copy link
Member

@evanh evanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markstory
Copy link
Member Author

Updates to demo mode are in #28503. I will rebase this once those changes are out.

@markstory markstory merged commit c18a6ac into master Sep 23, 2021
@markstory markstory deleted the ref-cleanup-tasks branch September 23, 2021 15:03
getsentry-bot added a commit that referenced this pull request Sep 23, 2021
This reverts commit c18a6ac.

Co-authored-by: mark via Slack <mark@sentry.io>
markstory added a commit that referenced this pull request Sep 23, 2021
vuluongj20 pushed a commit that referenced this pull request Sep 30, 2021
With all of these async deletions being done with ScheduledDeletion we
no longer need to have these tasks and their tests around.
vuluongj20 pushed a commit that referenced this pull request Sep 30, 2021
This reverts commit c18a6ac.

Co-authored-by: mark via Slack <mark@sentry.io>
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants