Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py38: import conversions to collections.abc where applicable #28432

Merged
merged 3 commits into from
Sep 21, 2021

Conversation

joshuarli
Copy link
Member

In Python 3.8, we get huge amounts of DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop working. This fixes that.

@joshuarli joshuarli requested review from evanpurkhiser and a team September 7, 2021 22:20
@joshuarli joshuarli requested a review from a team as a code owner September 7, 2021 22:20
@joshuarli joshuarli removed request for a team and evanpurkhiser September 7, 2021 22:20
Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we mark these old imports as errors so that we don't regress here?

@joshuarli joshuarli merged commit d15e14f into master Sep 21, 2021
@joshuarli joshuarli deleted the py38/collections-abc branch September 21, 2021 21:30
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants