feat(semver): Determine latest release using semver when applicable #27733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedetefy
reviewed
Jul 26, 2021
src/sentry/models/release.py
Outdated
| )[:10] | ||
| ) | ||
|
|
||
| if not releases_list: |
There was a problem hiding this comment.
oops I forgot to handle that .. thanks for adding that 😅
ahmedetefy
approved these changes
Jul 26, 2021
7ec6104 to
92edbbd
Compare
`latest` release currently only works based on release date. This changes is to use semver for projects where semver is in use. If multiple projects are being checked, for the moment we'll fall back to date released.
a2870cb to
9bdea38
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
latestrelease currently only works based on release date. This changes is to use semver forprojects where semver is in use. If multiple projects are being checked, for the moment we'll fall
back to date released.
We also switch
latestto fetch the latest release for all selected projects. To do this we had tofall back to raw sql, since even though Django does support window functions now, we don't have
a good way to filter on the
rankwindow function