Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[User Feedback] Re-label activity related to feedbacks so it doesn't say 'issue', should be 'feedback' #64284

Closed
Tracked by #61372
ryan953 opened this issue Jan 31, 2024 · 1 comment · Fixed by #64325
Closed
Tracked by #61372

[User Feedback] Re-label activity related to feedbacks so it doesn't say 'issue', should be 'feedback' #64284

ryan953 opened this issue Jan 31, 2024 · 1 comment · Fixed by #64325
Assignees
@michellewzhang

Comments

@ryan953
Copy link
Member

ryan953 commented Jan 31, 2024 •
edited
Loading

SCR-20240131-ikzt

I'm noticing 2 things in this screen shot:

  • We're calling things Issues, but they should be called feedbacks
  • we're using the words "archived" instead of spam

To repro this activity on another feedback, do the following:

  • Find a feedback in the inbox
  • Mark it as resolved (the activity message for this is mostly fine)
  • Next, after it's resolved, convert it directly to spam (results in the "archived this issue forever" label)

We should also check the messages for going back to the inbox and see if they need to be re-labelled.
@ryan953 ryan953 mentioned this issue Jan 31, 2024
Closed
@ryan953 ryan953 changed the title [User Feedback] Re-label activity related to feedbacks so it doens't say 'issue' or 'archived', should be 'feedback' and 'resolved' [User Feedback] Re-label activity related to feedbacks so it doesn't say 'issue', should be 'feedback' Jan 31, 2024
@ryan953
Copy link
Member Author

ryan953 commented Jan 31, 2024

not a burning problem at this stage of the project. i haven’t looked at how we could approach fixing it.

@michellewzhang michellewzhang self-assigned this Jan 31, 2024
@michellewzhang michellewzhang mentioned this issue Jan 31, 2024
Merged
michellewzhang added a commit that referenced this issue Jan 31, 2024
@michellewzhang
ref(feedback): adjust activity section wording (#64325)
d729888 
- Closes #64284
- Only adjusted the comments that currently to feedback: (un)resolve,
(un)assign, mark as spam, (un)resolve via integration (don't think this
one applies yet actually)

<img width="786" alt="SCR-20240131-mscu"
src="https://github.com/getsentry/sentry/assets/56095982/46ecd282-2456-40d1-96f5-f51d55f35d2f">
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@michellewzhang michellewzhang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ref(feedback): adjust activity section wording getsentry/sentry
2 participants
@ryan953 @michellewzhang