-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show UI frames, CPU and Memory for RN/iOS Mixed Profiles #59989
Comments
Routing to @getsentry/product-owners-profiling for triage ⏲️ |
Hi, is there an estimate on when CPU and Memory usage will be available for RN? |
@krystofwoldrich I cant access that flamegraph you shared. Mind sending me one where measurements were sent? I'm going to look enabling this, iirc it's just a matter of adding the platform to a whitelist that determines if the charts should be rendered. |
Nevermind, I found it and I'm working on enabling this. |
…are sent (#71258) React native uses javascript as the platform value which is used both by browser sdk which doesnt report cpu and memory measures. This means we cant know ahead of time if we expect the measurements and simply enable the charts (this toggles loading and the various no measurement states). In order to not enable these charts for browser SDKs and confuse users, we take a different approach and enable the charts on demand, once the data has loaded. We miss out on some of the loading states, but this all happens pretty fast as the profile loads, so I dont think it's a big deal in terms of UX. Fixes #59989
…are sent (#71258) React native uses javascript as the platform value which is used both by browser sdk which doesnt report cpu and memory measures. This means we cant know ahead of time if we expect the measurements and simply enable the charts (this toggles loading and the various no measurement states). In order to not enable these charts for browser SDKs and confuse users, we take a different approach and enable the charts on demand, once the data has loaded. We miss out on some of the loading states, but this all happens pretty fast as the profile loads, so I dont think it's a big deal in terms of UX. Fixes #59989
Since getsentry/sentry-react-native#3349 RN SDK sends profiles with UI frames, CPU and Memory.
https://sentry-sdks.sentry.io/profiling/profile/sentry-react-native/4f0be51bd1534274b5b0fc1874520fd8/flamegraph/
The current UI doesn't display the measurements.
Note not all RN profiles include the measurements.
The text was updated successfully, but these errors were encountered: