Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up integration-docs-platforms #54835

Closed
Tracked by #53855
matejminar opened this issue Aug 16, 2023 · 1 comment
Closed
Tracked by #53855

Clean up integration-docs-platforms #54835

matejminar opened this issue Aug 16, 2023 · 1 comment
Assignees

Comments

@matejminar
Copy link
Member

matejminar commented Aug 16, 2023

Once the profiling and replay docs are moved over to the sentry repo, we can do a cleanup of integration-docs-platforms.
That would include:

  • Webpack configuration that sets up this integration-docs-platforms alias
  • Webpack plugin to download
  • Python implementation to download

See https://github.com/getsentry/sentry/pull/54678/files#r1293806721

@ArthurKnaus
Copy link
Member

ArthurKnaus commented Sep 18, 2024

I checked the current implementation, there is no webpack plugin anymore. However, there is a different mechanism now.
What remains to do is:

  1. Remove / Migrate Inline docs that are shown in the trace view for spans that are missing instrumentation.
  2. Remove the build-platform-assets build step that downloads the docs on backend build (see _integration_docs.py)
  3. Remove ProjectDocsPlatformEndpoint

ArthurKnaus added a commit that referenced this issue Sep 26, 2024
Move static docs content into InlineDocs component.

Part of #54835
ArthurKnaus added a commit that referenced this issue Sep 30, 2024
The endpoint is private and unused in our app.

part of #54835
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants