Skip to content

Commit

Permalink
fix: Treat empty/null values as undefined
Browse files Browse the repository at this point in the history
Fixes #12777
  • Loading branch information
dcramer committed Apr 19, 2019
1 parent d3eeaca commit df86f73
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/sentry/static/sentry/app/views/installWizard.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,10 @@ export default class InstallWizard extends AsyncView {
// XXX(dcramer): we need the user to explicitly choose beacon.anonymous
// vs using an implied default so effectively this is binding
// all values to their server-defaults (as client-side defaults dont really work)
// TODO(dcramer): we need to rethink this logic as doing multiple "is this value actually set"
// is problematic
if (
option.value !== undefined &&
option.value !== undefined && option.value !== "" && option.value !== null &&
(option.field.isSet || optionName != 'beacon.anonymous')
) {
data[optionName] = option.value;
Expand Down

0 comments on commit df86f73

Please sign in to comment.