-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(dev): Patch firefox_profile.py from Selenium package (#29887)
Running `pytest` in `getsentry` triggers a bug in `firefox_profile.py` from the Selenium driver. Upgrading to version 4 is quite involved. This is a stop-gap to prevent distracting engineers when it happens.
- Loading branch information
Showing
3 changed files
with
15 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- .venv/lib/python3.8/site-packages/selenium/webdriver/firefox/firefox_profile.py 2021-11-09 16:40:20.000000000 -0500 | ||
+++ .venv/lib/python3.8/site-packages/selenium/webdriver/firefox/firefox_profile.py.bak 2021-11-09 16:40:03.000000000 -0500 | ||
@@ -207,3 +207,3 @@ | ||
def _set_manual_proxy_preference(self, key, setting): | ||
- if setting is None or setting is '': | ||
+ if setting is None or setting == '': | ||
return |