chore(performance): Delete is-key-transaction endpoint (#28656)

This is the last reference to the original key transaction table. Once this is removed, we can drop the table.
getsentry · Sep 17, 2021 · 863f6f7 · 863f6f7
1 parent 4350bea
commit 863f6f7
Show file tree

Hide file tree

Showing 8 changed files with 1 addition and 58 deletions.
diff --git a/src/sentry/api/urls.py b/src/sentry/api/urls.py
@@ -7,7 +7,6 @@
 from sentry.data_export.endpoints.data_export import DataExportEndpoint
 from sentry.data_export.endpoints.data_export_details import DataExportDetailsEndpoint
 from sentry.discover.endpoints.discover_key_transactions import (
-    IsKeyTransactionEndpoint,
     KeyTransactionEndpoint,
     KeyTransactionListEndpoint,
 )
@@ -837,11 +836,6 @@
                     KeyTransactionListEndpoint.as_view(),
                     name="sentry-api-0-organization-key-transactions-list",
                 ),
-                url(
-                    r"^(?P<organization_slug>[^\/]+)/is-key-transactions/$",
-                    IsKeyTransactionEndpoint.as_view(),
-                    name="sentry-api-0-organization-is-key-transactions",
-                ),
                 url(
                     r"^(?P<organization_slug>[^\/]+)/related-issues/$",
                     OrganizationEventsRelatedIssuesEndpoint.as_view(),

diff --git a/src/sentry/discover/endpoints/discover_key_transactions.py b/src/sentry/discover/endpoints/discover_key_transactions.py
@@ -11,7 +11,7 @@
 from sentry.api.serializers import Serializer, register, serialize
 from sentry.api.utils import InvalidParams
 from sentry.discover.endpoints import serializers
-from sentry.discover.models import KeyTransaction, TeamKeyTransaction
+from sentry.discover.models import TeamKeyTransaction
 from sentry.models import ProjectTeam, Team
 
 
@@ -24,30 +24,6 @@ class KeyTransactionPermission(OrganizationPermission):
     }
 
 
-class IsKeyTransactionEndpoint(KeyTransactionBase):
-    permission_classes = (KeyTransactionPermission,)
-
-    def get(self, request, organization):
-        """Get the Key Transactions for a user"""
-        if not self.has_feature(request, organization):
-            return Response(status=404)
-
-        project = self.get_project(request, organization)
-
-        transaction = request.GET.get("transaction")
-
-        try:
-            KeyTransaction.objects.get(
-                organization=organization,
-                owner=request.user,
-                project=project,
-                transaction=transaction,
-            )
-            return Response({"isKey": True}, status=200)
-        except KeyTransaction.DoesNotExist:
-            return Response({"isKey": False}, status=200)
-
-
 class KeyTransactionEndpoint(KeyTransactionBase):
     permission_classes = (KeyTransactionPermission,)
 

diff --git a/tests/js/spec/views/performance/transactionEvents.spec.tsx b/tests/js/spec/views/performance/transactionEvents.spec.tsx
@@ -49,11 +49,6 @@ describe('Performance > TransactionSummary', function () {
       body: [],
     });
     // @ts-expect-error
-    MockApiClient.addMockResponse({
-      url: '/organizations/org-slug/is-key-transactions/',
-      body: [],
-    });
-    // @ts-expect-error
     MockApiClient.addMockResponse({
       url: '/prompts-activity/',
       body: {},

diff --git a/tests/js/spec/views/performance/transactionSummary.spec.jsx b/tests/js/spec/views/performance/transactionSummary.spec.jsx
@@ -90,10 +90,6 @@ describe('Performance > TransactionSummary', function () {
       url: '/prompts-activity/',
       body: {},
     });
-    MockApiClient.addMockResponse({
-      url: '/organizations/org-slug/is-key-transactions/',
-      body: [],
-    });
 
     // Mock totals for the sidebar and other summary data
     MockApiClient.addMockResponse(

diff --git a/tests/js/spec/views/performance/transactionSummary/transactionEvents/content.spec.tsx b/tests/js/spec/views/performance/transactionSummary/transactionEvents/content.spec.tsx
@@ -73,11 +73,6 @@ describe('Performance Transaction Events Content', function () {
       body: [],
     });
     // @ts-expect-error
-    MockApiClient.addMockResponse({
-      url: '/organizations/org-slug/is-key-transactions/',
-      body: [],
-    });
-    // @ts-expect-error
     MockApiClient.addMockResponse({
       url: '/prompts-activity/',
       body: {},

diff --git a/tests/js/spec/views/performance/transactionSummary/transactionEvents/eventsTable.spec.tsx b/tests/js/spec/views/performance/transactionSummary/transactionEvents/eventsTable.spec.tsx
@@ -77,11 +77,6 @@ describe('Performance GridEditable Table', function () {
       body: [],
     });
     // @ts-expect-error
-    MockApiClient.addMockResponse({
-      url: '/organizations/org-slug/is-key-transactions/',
-      body: [],
-    });
-    // @ts-expect-error
     MockApiClient.addMockResponse({
       url: '/prompts-activity/',
       body: {},

diff --git a/tests/js/spec/views/performance/transactionTags/index.spec.jsx b/tests/js/spec/views/performance/transactionTags/index.spec.jsx
@@ -46,10 +46,6 @@ describe('Performance > Transaction Tags', function () {
       url: '/organizations/org-slug/tags/user.email/values/',
       body: [],
     });
-    MockApiClient.addMockResponse({
-      url: '/organizations/org-slug/is-key-transactions/',
-      body: [],
-    });
     MockApiClient.addMockResponse({
       url: '/organizations/org-slug/events-facets-performance/',
       body: {

diff --git a/tests/js/spec/views/performance/transactionVitals.spec.jsx b/tests/js/spec/views/performance/transactionVitals.spec.jsx
@@ -71,10 +71,6 @@ describe('Performance > Web Vitals', function () {
       url: '/organizations/org-slug/projects/',
       body: [],
     });
-    MockApiClient.addMockResponse({
-      url: '/organizations/org-slug/is-key-transactions/',
-      body: [],
-    });
     MockApiClient.addMockResponse({
       url: '/organizations/org-slug/project-transaction-threshold-override/',
       method: 'GET',