ref(js): Remove organization.projects usage in GroupDetails

getsentry · Sep 21, 2021 · 3b499b2 · 3b499b2
1 parent f2dd7f4
commit 3b499b2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/static/app/views/organizationGroupDetails/groupDetails.tsx b/static/app/views/organizationGroupDetails/groupDetails.tsx
@@ -36,6 +36,7 @@ type Error = typeof ERROR_TYPES[keyof typeof ERROR_TYPES] | null;
 type Props = {
   api: Client;
   organization: Organization;
+  projects: Project[];
   environments: string[];
   children: React.ReactNode;
   isGlobalSelectionReady: boolean;
@@ -438,8 +439,7 @@ class GroupDetails extends React.Component<Props, State> {
   }
 
   renderError() {
-    const {organization, location} = this.props;
-    const projects = organization.projects ?? [];
+    const {projects, location} = this.props;
     const projectId = location.query.project;
 
     const projectSlug = projects.find(proj => proj.id === projectId)?.slug;

diff --git a/static/app/views/organizationGroupDetails/index.tsx b/static/app/views/organizationGroupDetails/index.tsx
@@ -1,17 +1,19 @@
 import * as React from 'react';
 import {RouteComponentProps} from 'react-router';
 
-import {GlobalSelection, Organization} from 'app/types';
+import {GlobalSelection, Organization, Project} from 'app/types';
 import {analytics, metric} from 'app/utils/analytics';
 import withGlobalSelection from 'app/utils/withGlobalSelection';
 import withOrganization, {isLightweightOrganization} from 'app/utils/withOrganization';
+import withProjects from 'app/utils/withProjects';
 
 import GroupDetails from './groupDetails';
 
 type Props = {
   selection: GlobalSelection;
   isGlobalSelectionReady: boolean;
   organization: Organization;
+  projects: Project[];
   children: React.ReactNode;
 } & RouteComponentProps<{orgId: string; groupId: string}, {}>;
 
@@ -53,4 +55,6 @@ class OrganizationGroupDetails extends React.Component<Props> {
   }
 }
 
-export default withOrganization(withGlobalSelection(OrganizationGroupDetails));
+export default withOrganization(
+  withProjects(withGlobalSelection(OrganizationGroupDetails))
+);