Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref!: Upgrade main node version to v18 #793

Merged
merged 7 commits into from
Feb 17, 2025
Merged

ref!: Upgrade main node version to v18 #793

merged 7 commits into from
Feb 17, 2025

Conversation

BYK
Copy link
Member

@BYK BYK commented Feb 14, 2025

Prerequisite for #758.

@BYK BYK requested a review from Lms24 February 14, 2025 15:55
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.21%. Comparing base (2d692f7) to head (db30574).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master     #793    +/-   ##
========================================
  Coverage   50.21%   50.21%            
========================================
  Files          52       52            
  Lines        3529     3529            
  Branches      880      894    +14     
========================================
  Hits         1772     1772            
+ Misses       1756     1572   -184     
- Partials        1      185   +184     
Flag Coverage Δ
e2e-tests 85.29% <ø> (ø)
unit-tests 48.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BYK BYK changed the title ref: Upgrade main node version to v20 ref: Upgrade main node version to v18 Feb 14, 2025
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we drop support for Node < 18.20.6, we can also remove 14 and 16 from the test matrix in the build.yml worflow

@BYK BYK changed the title ref: Upgrade main node version to v18 ref!: Upgrade main node version to v18 Feb 14, 2025
@BYK BYK requested a review from Lms24 February 14, 2025 22:30
@BYK BYK merged commit 3d19011 into master Feb 17, 2025
19 checks passed
@BYK BYK deleted the byk/ref/upgrade-node branch February 17, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants