feat(nextjs): Create next.config.mjs when package.json has type: "module"
#699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lms24
approved these changes
Oct 30, 2024
Comment on lines
+571
to
+577
| const packageJsonText = await fs.promises.readFile( | ||
| path.join(process.cwd(), 'package.json'), | ||
| 'utf8', | ||
| ); | ||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment | ||
| const packageJson = JSON.parse(packageJsonText); | ||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access |
There was a problem hiding this comment.
l: We can also use getPackageDotJson from clack-utils.ts instead of reading and parsing manually here
There was a problem hiding this comment.
Thought about it but it had too much logic and logging in case it failed.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should create a little less friction in case users set
type: modulein their package json.