-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remix): Add feature selection #646
Conversation
|
0f619dc
to
e1f0031
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is almost ready to go. Let's just adjust the error message, then we can merge it. Discovered another issue while reviewing and reported it in #664 but let's tackle this separately.
src/remix/remix-wizard.ts
Outdated
prompt: `Do you want to enable ${chalk.bold( | ||
'Sentry Session Replay', | ||
)} to get reproduction of frontend errors via user sessions?`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's adjust the message here analogously to SvelteKit/NextJS
@@ -24,7 +24,7 @@ jobs: | |||
- name: Pack | |||
run: yarn pack | |||
- name: Archive Artifacts | |||
uses: actions/upload-artifact@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lms24 - I bumped this due to failing CI runs (https://github.com/getsentry/sentry-wizard/actions/runs/10769670335)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Onur!
Ref: #622