Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix): Add feature selection #646

Merged
merged 7 commits into from
Sep 9, 2024
Merged

Conversation

onurtemizkan
Copy link
Collaborator

Ref: #622

Copy link

github-actions bot commented Aug 8, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 9fdf4df

@onurtemizkan onurtemizkan force-pushed the onur/feature-selection-remix branch from 0f619dc to e1f0031 Compare August 8, 2024 11:40
@Lms24 Lms24 self-requested a review September 6, 2024 09:02
@Lms24 Lms24 self-assigned this Sep 6, 2024
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is almost ready to go. Let's just adjust the error message, then we can merge it. Discovered another issue while reviewing and reported it in #664 but let's tackle this separately.

Comment on lines 90 to 92
prompt: `Do you want to enable ${chalk.bold(
'Sentry Session Replay',
)} to get reproduction of frontend errors via user sessions?`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's adjust the message here analogously to SvelteKit/NextJS

@@ -24,7 +24,7 @@ jobs:
- name: Pack
run: yarn pack
- name: Archive Artifacts
uses: actions/upload-artifact@v2
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Onur!

@Lms24 Lms24 merged commit 132439d into master Sep 9, 2024
13 checks passed
@Lms24 Lms24 deleted the onur/feature-selection-remix branch September 9, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants