feat(nextjs): Add feature selection #631
Conversation
|
947aa1e to
c7ef8a0
Compare
test/nextjs/templates.test.ts
Outdated
| @@ -82,6 +98,20 @@ describe('NextJS code templates', () => { | |||
| // side errors will fail. | |||
| tunnelRoute: "/monitoring", | |||
|
|
|||
| async headers() { | |||
There was a problem hiding this comment.
I think this has to be put in the actual Next.js config - not the SDK config :/ But that can get very complicated, we could leave profiling out for now.
src/utils/clack-utils.ts
Outdated
| export async function askShouldUseDefaulFeatureSet(): Promise<boolean> { | ||
| return traceStep('ask-use-default-feature-set', () => | ||
| abortIfCancelled( | ||
| clack.confirm({ | ||
| message: 'Do you want to use the default feature set?', | ||
| initialValue: true, | ||
| }), | ||
| ), | ||
| ); | ||
| } |
There was a problem hiding this comment.
Let's not give users this option! I think it is valuable for them to walk through what they are missing out on.
src/nextjs/nextjs-wizard.ts
Outdated
| export const NEXTJS_FEATURE_SET: Feature[] = [ | ||
| { | ||
| id: 'performance', | ||
| name: 'Performance Monitoring', | ||
| }, | ||
| { | ||
| id: 'replay', | ||
| name: 'Session Replay', | ||
| }, | ||
| { | ||
| id: 'profiling', | ||
| name: 'Profiling', | ||
| }, | ||
| { | ||
| id: 'spotlight', | ||
| name: 'Spotlight', | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
One big part of giving users the option to select and deselct features is that we get to briefly explain these concepts to them, so ideally we give them short but valuable descriptions on all of these!
2e7b17f to
37eb3a2
Compare
src/nextjs/nextjs-wizard.ts
Outdated
| { | ||
| id: 'performance', | ||
| name: 'Performance Monitoring', | ||
| description: 'Monitor your app performance and find bottlenecks.', | ||
| recommended: true, | ||
| }, | ||
| { | ||
| id: 'replay', | ||
| name: 'Session Replay', | ||
| description: 'Replay user sessions to reproduce and fix bugs.', | ||
| }, | ||
| { | ||
| id: 'spotlight', | ||
| name: 'Spotlight', | ||
| description: `Use Sentry's Spotlight debug tool (https://spotlightjs.com/) for your development workflow.`, | ||
| }, |
There was a problem hiding this comment.
@lforst - Please feel free to update the descriptions I added here
src/utils/clack-utils.ts
Outdated
|
|
||
| export async function featureSelectionPrompt(features: Feature[]) { | ||
| return traceStep('feature-selection', async () => { | ||
| return clack.multiselect({ |
There was a problem hiding this comment.
I think it would be good to give every option its own yes/no step. 🤔 We can keep the features logic though, I like that!
src/nextjs/nextjs-wizard.ts
Outdated
| id: 'performance', | ||
| name: 'Performance Monitoring', | ||
| description: 'Monitor your app performance and find bottlenecks.', | ||
| recommended: true, |
There was a problem hiding this comment.
I am not sure if recommendations make to much sense 😄 technically all of the features are always recommended.
863a13d to
bdb6aa0
Compare
bdb6aa0 to
85794d2
Compare
Part of: #622
This PR introduces:
Spotlight (optionally generates config for it but it's still commented out like before)(Spotlight needs more setup and we'll do in a follow-up)