Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Fix Types of GlobalError #592

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Jun 18, 2024

Adding a TS snippet for GlobalError.
fixes getsentry/sentry-javascript#12520

@s1gr1d s1gr1d requested review from lforst and andreiborza June 18, 2024 07:45
@@ -392,7 +416,7 @@ export default function GlobalError({ error }) {
return (
<html>
<body>
<Error />
<NextError statusCode={error.props?.statusCode || 0} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update this.

@lforst lforst merged commit fd473e0 into master Jun 19, 2024
4 checks passed
@lforst lforst deleted the sig/nextjs-global-error branch June 19, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global error page installed by wizard causes TypeScript compilation errors during Next 14 build step
2 participants