-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-native): Add support for Expo managed projects #505
Conversation
|
…ed versions after confirm
@lucas-zimerman you can also take a look. 🙏 |
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
After the release of the new wizard, we should update the docs here https://docs.sentry.io/platforms/react-native/ on how to setup an expo project.
Yes, related docs PR here. |
DO NOT MERGE! The current implementation overwrites Expo default Add check for |
@krystofwoldrich is this ready for a review? (no rush, just trying to catch up with wizard stuff after PTO 😅) |
@Lms24 Thank you for the message, yes, since the morning it's ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from general wizard perspective! I couldn't test it though as I don't have an RN test environment, so deferring this to other reviewers/you :)
All good to merge from my end!
This PR adds support for Expo project (with and without native dirs).
The support includes:
app.json
configuration file with@sentry/react-native/expo
metro.config.json
with@sentry/react-native/metro
getSentryExpoConfig
sentry-xcode.sh
.env.local
with Sentry Auth Token.env.local