-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sentry serializer to RN metro config #502
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from general wizard perspective! Also thanks for adding the tests - makes it much easier to understand what's going on when reviewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comment/not relevant for this PR: AFAICT, the RN wizard is the only one that supports uninstall logic (maybe electron has it as well, not sure). I was wondering if we should consider dropping uninstall support since most of our wizard flows don't do this and it takes a considerable amount logic to work properly. WDYT?
Btw, not saying we have to do this, just a thought. I'm happy to keep it around but at the same time I think it's unlikely that we'll add it to JS or source maps wizards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, it adds a bit of overhead. We could drop it in the future in favor of a doc page documenting the uninstall steps. Or we can limit it to the native parts which are in general had for JS dev to unpatch.
This PR adds ability to patch
metro.config.js
in RN project and automatically add the Sentry Metro plugin as released in https://github.com/getsentry/sentry-react-native/releases/tag/5.11.0Example patch: