Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(sveltekit): Add log for successful Vite plugin insertion #465

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Sep 19, 2023

Realized that we didn't log anything about modifying users' Vite config in the SvelteKit wizard. This PR fixes that.
Also, I forgot to add the success tag - that explains why our SvelteKit dashboard only shows Vite plugin insertion fails 😅

@Lms24 Lms24 requested a review from AbhiPrasad September 19, 2023 12:58
@Lms24 Lms24 force-pushed the lms/fix-sveltekit-telemetry-vite-cfg-success branch from eda3ac8 to 24e1fa7 Compare September 19, 2023 13:35
@Lms24 Lms24 merged commit b1a4d8e into master Sep 20, 2023
@Lms24 Lms24 deleted the lms/fix-sveltekit-telemetry-vite-cfg-success branch September 20, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants