Json for Sentry config #80
Conversation
|
Please notice, currently the json config generated dynamically and not included in the project. |
There was a problem hiding this comment.
The approach is great! Will also perform better and since we're anyway dependant on S.T.J might as well use it.
Good thing now we can take advantage of that nice testing infrastrucutre you've setup to get these code tested. Will be particularly nice to make sure the serialization round-trip works. Would also be good to have some snapshot tests to validate we're not introducing breakage on serialzied files, as we ship new versions
| public void SentryTestWindow_OpenAndLinkXmlCopied_Successful() | ||
| { | ||
| LogAssert.ignoreFailingMessages = true; // mandatory | ||
|
|
||
| // Open & Close window to trigger 'link.xml' logic | ||
| SentryTestWindow.Open().Dispose(); | ||
|
|
||
| var linkXmlPath = $"{Application.dataPath}/Resources/{UnitySentryOptions.ConfigRootFolder}/link.xml"; | ||
| Assert.IsTrue(File.Exists(linkXmlPath)); | ||
| } |
There was a problem hiding this comment.
What about we make sure it wasn't there to begin with. Or should we delete it before the test runs?
| public void SentryTestWindow_OpenAndLinkXmlCopied_Successful() | |
| { | |
| LogAssert.ignoreFailingMessages = true; // mandatory | |
| // Open & Close window to trigger 'link.xml' logic | |
| SentryTestWindow.Open().Dispose(); | |
| var linkXmlPath = $"{Application.dataPath}/Resources/{UnitySentryOptions.ConfigRootFolder}/link.xml"; | |
| Assert.IsTrue(File.Exists(linkXmlPath)); | |
| } | |
| public void SentryTestWindow_OpenAndLinkXmlCopied_Successful() | |
| { | |
| var linkXmlPath = $"{Application.dataPath}/Resources/{UnitySentryOptions.ConfigRootFolder}/link.xml"; | |
| Assert.IsFalse(File.Exists(linkXmlPath)); // sanity check | |
| LogAssert.ignoreFailingMessages = true; // mandatory | |
| // Open & Close window to trigger 'link.xml' logic | |
| SentryTestWindow.Open().Dispose(); | |
| Assert.IsTrue(File.Exists(linkXmlPath)); | |
| } | |
| var jsonRaw = File.ReadAllText(optionsFilePath); | ||
| using var jsonDocument = JsonDocument.Parse(jsonRaw); | ||
|
|
||
| UnitySentryOptions.FromJson(jsonDocument.RootElement); |
There was a problem hiding this comment.
This is missing the asserts I assume?
No
ScriptableObjectfor Sentry config. Quick & dirty.UnitySentryOptionsreusedlink.xmlmust be placed inside Unity project for IL2CPP builds to workAPI 30(Android 11, ARM, please read notes below) viaAndroid Studioemulator*.apksize ~19mb*.apksize ~29mbNote: currently the json config generated dynamically and not included in the project.
Android notes:
Unitydropped support forx86_x86forAndroid.Android Studiorecommendation is to use emulator images which are based onx86, butUnitybuilds only forARM.ARMis much slower in terms of performance. Google recently made an update forx86images to supportARMin a performant way, but it works only forAPI 30(Android 11).If you try to use any previous
ARMbased images which are not tuned forx86, you will see the following messageIt's so slow that I didn't wait enough for it to start...
This is an example of how it looks inside
AVD.Android 11usesx86-ARM-comptaiblearch, whileAndroid 4.4usesplain-old-ARMAnother option is to use something like Blustacks or Genymotion (they also provide Android-as-a-Service). I had some
Hyper-Vproblems running Bluestacks, because of aDockerwhich is always running on my system.